cloud-init-dev team mailing list archive

[Chad Smith <chad.smith@xxxxxxxxxxxxx>]

@scott I think I've addressed all comments here 


Diff comments:

> diff --git a/packages/pkg-deps.json b/packages/pkg-deps.json
> new file mode 100644
> index 0000000..2100ec7
> --- /dev/null
> +++ b/packages/pkg-deps.json
> @@ -0,0 +1,84 @@
> +{
> +   "debian" : {
> +      "build-requires" : [
> +         "debhelper",
> +         "dh-python",
> +         "dh-systemd"
> +      ],
> +      "renames" : {
> +         "pep8" : {
> +            "2" : "pep8",

dropped as we are only looking to support xenial and greater currently for pkg builds etc. We can deal with this if we have to SRU to trusty for a customer

> +            "3" : "python3-pep8"
> +         },
> +         "pyflakes" : {

Good points, since master is really only generally targeting (via SRUs) xenial and above I've dropped some renames that don't matter anymore. We can add more distro-specific pkg renames in if end up having to pull a giant SRU into trusty.

> +            "2" : "pyflakes",
> +            "3" : "pyflakes"
> +         },
> +         "pyyaml" : {
> +            "2" : "python-yaml",
> +            "3" : "python3-yaml"
> +         },
> +         "six" : {
> +            "2" : "python-six",

yep removed.

> +            "3" : "python3-six"
> +         },
> +         "contextlib2" : {
> +            "2" : "python-contextlib2",
> +            "3" : null
> +         },
> +         "pyserial" : {
> +            "2" : "python-serial",
> +            "3" : "python3-serial"
> +         }
> +      },
> +      "requires" : [
> +         "procps"
> +      ]
> +   },
> +   "redhat" : {
> +      "build-requires" : [
> +         "python-devel",
> +         "python-setuptools"
> +      ],
> +      "renames" : {
> +         "pyyaml" : {
> +            "2" : "PyYAML",

null means use default.

> +            "3" : null
> +         },
> +         "pyserial" : {
> +            "2" : "pyserial",
> +            "3" : null
> +         }

Yeah strange I can't find pyserial either on centos, though I see references to it at http://pyserial.readthedocs.io/en/latest/pyserial.html. We also have the expectation of that missing deps within a try/except ImportError block so we are good not documenting it.

> +      },
> +      "requires" : [
> +         "e2fsprogs",
> +         "iproute",
> +         "net-tools",
> +         "procps",
> +         "rsyslog",
> +         "shadow-utils",
> +         "sudo >= 1.7.2p2-3"
> +      ]
> +   },
> +   "suse" : {
> +      "renames" : {
> +         "pyyaml" : {
> +            "2" : "python-yaml",
> +            "3" : null
> +         }
> +      },
> +      "build-requires" : [
> +         "fdupes",
> +         "filesystem",
> +         "python-devel",
> +         "python-setuptools"
> +      ],
> +      "requires" : [
> +         "iproute2",
> +         "e2fsprogs",
> +         "net-tools",
> +         "procps",
> +         "sudo"
> +      ]
> +   }
> +}


-- 
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325342
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:ci-deps into cloud-init:master.