cloud-init-dev team mailing list archive

[Scott Moser <smoser@xxxxxxxxxx>]

'null' seems to have a different meaning for pyyaml and pyserial.
that needs to be cleaned up, but i dont have anything other comments.

(i realize that we're not going to be buildling rhel python34 at the moment, so this is reasonably lower priority).


Diff comments:

> diff --git a/packages/pkg-deps.json b/packages/pkg-deps.json
> new file mode 100644
> index 0000000..2100ec7
> --- /dev/null
> +++ b/packages/pkg-deps.json
> @@ -0,0 +1,84 @@
> +{
> +   "debian" : {
> +      "build-requires" : [
> +         "debhelper",
> +         "dh-python",
> +         "dh-systemd"
> +      ],
> +      "renames" : {
> +         "pep8" : {
> +            "2" : "pep8",
> +            "3" : "python3-pep8"
> +         },
> +         "pyflakes" : {
> +            "2" : "pyflakes",
> +            "3" : "pyflakes"
> +         },
> +         "pyyaml" : {
> +            "2" : "python-yaml",
> +            "3" : "python3-yaml"
> +         },
> +         "six" : {
> +            "2" : "python-six",
> +            "3" : "python3-six"
> +         },
> +         "contextlib2" : {
> +            "2" : "python-contextlib2",
> +            "3" : null
> +         },
> +         "pyserial" : {
> +            "2" : "python-serial",
> +            "3" : "python3-serial"
> +         }
> +      },
> +      "requires" : [
> +         "procps"
> +      ]
> +   },
> +   "redhat" : {
> +      "build-requires" : [
> +         "python-devel",
> +         "python-setuptools"
> +      ],
> +      "renames" : {
> +         "pyyaml" : {
> +            "2" : "PyYAML",

What would that be then?
The two packages I see in centos7 and centos6 are:
  python2: PyYAML
  python3: python34-PyYAML

> +            "3" : null
> +         },
> +         "pyserial" : {
> +            "2" : "pyserial",
> +            "3" : null
> +         }

yeah, it sure seems like there isn't a python3 bindings for pyserial.
This is what lead me to ask about what 'null' means, because above you said "null means use default".  But clearly the default is not right here.

> +      },
> +      "requires" : [
> +         "e2fsprogs",
> +         "iproute",
> +         "net-tools",
> +         "procps",
> +         "rsyslog",
> +         "shadow-utils",
> +         "sudo >= 1.7.2p2-3"
> +      ]
> +   },
> +   "suse" : {
> +      "renames" : {
> +         "pyyaml" : {
> +            "2" : "python-yaml",
> +            "3" : null
> +         }
> +      },
> +      "build-requires" : [
> +         "fdupes",
> +         "filesystem",
> +         "python-devel",
> +         "python-setuptools"
> +      ],
> +      "requires" : [
> +         "iproute2",
> +         "e2fsprogs",
> +         "net-tools",
> +         "procps",
> +         "sudo"
> +      ]
> +   }
> +}


-- 
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325342
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:ci-deps into cloud-init:master.