← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~smoser/cloud-init:bug/before-fsck into cloud-init:master

 

Hi Balint --

Please fix up the structural problems with these MPs.

1) set this MP "rejected"
2) Also reference this MP in the description of
https://code.launchpad.net/~rbalint/cloud-init/+git/cloud-init/+merge/326252
3) Link the bug to the 326252 merge

Thanks!

On Tue, Jul 11, 2017 at 8:20 AM, Balint Reczey <balint.reczey@xxxxxxxxxxxxx>
wrote:

>
>
>
> > Balint,
> > How would that work?
>
> Please consider my previous comment superseded by this MP:
> https://code.launchpad.net/~rbalint/cloud-init/+git/cloud-
> init/+merge/326252
>
> I put a comment in the bug but forgot also noting it here.
>
> >
> > I think you're essentially saying to run:
> >  systemctl stop systemd-fsck@<something>.service
> >
> > But to do that, I have to figure out which are the appropriate values for
> > 'something'.  That could be 'dev-disk-by-uuid=XXXX',
> 'dev-disk-by-label=XXXX'
> > for any filesystem on the block device.
> >
> > Additionally, if I did:
> >  a. stop
> >  b. <try to reformat/adjust>
> >  c. restart
> > there is a potential that my 'stop' happens before has started.  does a
> 'stop'
> > of a service prevent it from starting if it would start later on its own?
> --
> https://code.launchpad.net/~smoser/cloud-init/+git/cloud-
> init/+merge/324191
> You are subscribed to branch cloud-init:master.
>
> Launchpad-Message-Rationale: Subscriber
> Launchpad-Message-For: davidpbritton
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~cloud-init-dev/cloud-init/+git/cloud-init:master
> Launchpad-Project: cloud-init
>



-- 
David Britton <david.britton@xxxxxxxxxxxxx>

https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324191
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/before-fsck into cloud-init:master.


References