← Back to team overview

cloud-init-dev team mailing list archive

Re: [Merge] ~smoser/cloud-init:bug/before-fsck into cloud-init:master

 

David,

Balint's work flow here is completely valid.
He was reviewing https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324191 and wanted to suggest a different path for fixes so he proposed a merge into that branch (~smoser/cloud-init:bug/before-fsck).

I often do the same when I think its easier to just show code for what i mean than explaining in words the changes I'd like.

The one thing I would suggest is that when that is done you should comment in the original merge proposal. something to the affect of:
  Hey, i thought of a different way to do this and worked up a merge proposal at http://.....
-- 
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324191
Your team cloud-init commiters is requested to review the proposed merge of ~smoser/cloud-init:bug/before-fsck into cloud-init:master.


Follow ups

References