cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] ~chad.smith/cloud-init:unittests-in-cloudinit-package into cloud-init:master

To: mp+327827@xxxxxxxxxxxxxxxxxx
From: Chad Smith <chad.smith@xxxxxxxxxxxxx>
Date: Thu, 27 Jul 2017 19:51:56 -0000
In-reply-to: <150057634000.6275.2644961279095635459.launchpad@ackee.canonical.com>
Reply-to: mp+327827@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Per our discussion today, I simplified logic in EphemeralIPv4Network context manager to first attempt to add a network address and handle a non-zero exit code if the address already exits.

All changes have been made per review comments, I separated out get_ip_info utility function so we can propose it as a separate branch to replace ifconfig parsing.
-- 
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:unittests-in-cloudinit-package into cloud-init:master.

References

[Merge] ~chad.smith/cloud-init:unittests-in-cloudinit-package into cloud-init:master
From: Chad Smith, 2017-07-20