← Back to team overview

cloud-init-dev team mailing list archive

[Merge] ~chad.smith/cloud-init:tests-fix-root-os-access-leak into cloud-init:master

 

The proposal to merge ~chad.smith/cloud-init:tests-fix-root-os-access-leak into cloud-init:master has been updated.

Commit Message changed to:

resizefs: Drop check and tests for read-only device file

As root user, os.access(<path>, os.W_OK) will always return True so that path will never get executed as Scott pointed out. Also, on a real read-only iscsi devpath, resizefs doesn't perform an operation on a filesystem it recognizes as read-only. It may emit a warning, but not cause a traceback.

For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330774
-- 
Your team cloud-init commiters is requested to review the proposed merge of ~chad.smith/cloud-init:tests-fix-root-os-access-leak into cloud-init:master.


References