cloud-init-dev team mailing list archive

Thread
Date

Re: [Merge] ~goneri/cloud-init:freebsd_nocloud into cloud-init:master

To: Gonéri Le Bouder <goneri@xxxxxxxxxxxx>
From: do3meli <info@xxxxxxxxxxxxxxxxxx>
Date: Tue, 23 Apr 2019 21:38:48 -0000
In-reply-to: <155461298061.8918.8926478533880425096.launchpad@ackee.canonical.com>
Reply-to: mp+365630@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

it might be useful to have some test cases that cover the linux way using blkid and having a case that covers the FreeBSD way so future addition/changes to the data source don't break things up again without noticing.

apart from that - looking at the code diff without really testing it - the change looks reasonable to me.
-- 
https://code.launchpad.net/~goneri/cloud-init/+git/cloud-init/+merge/365630
Your team cloud-init commiters is requested to review the proposed merge of ~goneri/cloud-init:freebsd_nocloud into cloud-init:master.

References

[Merge] ~goneri/cloud-init:freebsd_nocloud into cloud-init:master
From: Gonéri Le Bouder, 2019-04-07