← Back to team overview

credativ team mailing list archive

[Bug 900302] Re: Bug inserted between 2 revisions in crm_lead.py

 

Hello Julien,

I have completely checked your issue. You have specified that about the
revision 4872 on 6.0 which is fixed the problem of lp:892273.

We have fixed this because, If we return only "res" then it creates a
dictionary of mail which we can seen in lead record. But If mail with
attachment can't fetch proper and we can't found the attachment, So we
have return res,att_ids, then att_ids returns a attachment of mail.

Your another issue, which is about the "warning in the server log" like
"[2011-11-22 10:36:25,041][testmail] WARNING:pop:[01]: ValidateError",
this also has fixed at same revision number.

So would you please check it again and notify us where you faced the
problem.

Thanks and waiting for your reply!

** Project changed: openobject-server => openobject-addons

** Summary changed:

- Bug inserted between 2 revisions in crm_lead.py
+ [V6]Bug inserted between 2 revisions in crm_lead.py

** Changed in: openobject-addons
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of OpenERP
Framework Experts, which is subscribed to OpenERP Server.
https://bugs.launchpad.net/bugs/900302

Title:
  [V6]Bug inserted between 2 revisions in crm_lead.py

Status in OpenERP Addons (modules):
  Incomplete

Bug description:
  There is a little problem between 2 revisions for crm.lead.py (for
  OpenERP 6)

  In revision 4871, the method "message_new" returns only the identifier of the created object:
                "return res"
  and in revision 4872, the same method returns 2 parameters:
                "return res,att_ids"

  And the problem is that in the last revision, it always returns 2
  arguments but the "calling methods" are always waiting for only one
  data in return. In exemple when we use the fetchmail addon (it depends
  on mail_gateway). When we launch a fetchmail with a new incoming mail
  who requires to be treated. We have an error (we only see a warning in
  the server log but no error shown to the user and the process is not
  completely done) because when it calls the method, he receives 2
  data's instead of one.

  In mailgateway(in the the closure "create_record" in the method "process_email"), we have this code:
  "            if hasattr(model_pool, 'message_new'):
                  res_id = model_pool.message_new(cr, uid, msg, context=context)"
  but res_id doesn't receive the ID but a tupple with the result of message_new. And so, there is some problems in the rest of the method because it uses "res_id" as an integer and not a tupple.

  Maybe this problem is encountered somewhere else where this method is
  called

  Kind Regards,

  Julien

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/900302/+subscriptions


References