← Back to team overview

credativ team mailing list archive

[Bug 900302] [NEW] Bug inserted between 2 revisions in crm_lead.py

 

Public bug reported:

There is a little problem between 2 revisions for crm.lead.py (for
OpenERP 6)

In revision 4871, the method "message_new" returns only the identifier of the created object:
              "return res"
and in revision 4872, the same method returns 2 parameters:
              "return res,att_ids"

And the problem is that in the last revision, it always returns 2
arguments but the "calling methods" are always waiting for only one data
in return. In exemple when we use the fetchmail addon (it depends on
mail_gateway). When we launch a fetchmail with a new incoming mail who
requires to be treated. We have an error (we only see a warning in the
server log but no error shown to the user and the process is not
completely done) because when it calls the method, he receives 2 data's
instead of one.

In mailgateway(in the the closure "create_record" in the method "process_email"), we have this code:
"            if hasattr(model_pool, 'message_new'):
                res_id = model_pool.message_new(cr, uid, msg, context=context)"
but res_id doesn't receive the ID but a tupple with the result of message_new. And so, there is some problems in the rest of the method because it uses "res_id" as an integer and not a tupple.

Maybe this problem is encountered somewhere else where this method is
called

Kind Regards,

Julien

** Affects: openobject-server
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenERP
Framework Experts, which is subscribed to OpenERP Server.
https://bugs.launchpad.net/bugs/900302

Title:
  Bug inserted between 2 revisions in crm_lead.py

Status in OpenERP Server:
  New

Bug description:
  There is a little problem between 2 revisions for crm.lead.py (for
  OpenERP 6)

  In revision 4871, the method "message_new" returns only the identifier of the created object:
                "return res"
  and in revision 4872, the same method returns 2 parameters:
                "return res,att_ids"

  And the problem is that in the last revision, it always returns 2
  arguments but the "calling methods" are always waiting for only one
  data in return. In exemple when we use the fetchmail addon (it depends
  on mail_gateway). When we launch a fetchmail with a new incoming mail
  who requires to be treated. We have an error (we only see a warning in
  the server log but no error shown to the user and the process is not
  completely done) because when it calls the method, he receives 2
  data's instead of one.

  In mailgateway(in the the closure "create_record" in the method "process_email"), we have this code:
  "            if hasattr(model_pool, 'message_new'):
                  res_id = model_pool.message_new(cr, uid, msg, context=context)"
  but res_id doesn't receive the ID but a tupple with the result of message_new. And so, there is some problems in the rest of the method because it uses "res_id" as an integer and not a tupple.

  Maybe this problem is encountered somewhere else where this method is
  called

  Kind Regards,

  Julien

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-server/+bug/900302/+subscriptions


Follow ups

References