credativ team mailing list archive

[Joël Grand-Guillaume @ CampToCamp <joel.grandguillaume@xxxxxxxxxxxxxx>]

Public bug reported:

hi,


We've got an issue with encoding in the crm part. This will be difficult to reproduce.. :( So, please look at the code to understand the problem..

First bug part : Parsing the rules (base_action_rule) breaks if the
regexp or the name of the resource (model) has some non-string char. In
the function do_chek you have :

if reg_name:
            ptrn = re.compile(str(reg_name))
            _result = ptrn.search(str(obj.name))

Calling str() method here breaks if some unknown char are present in the
object name or in the regexp name it-self.

See my patch, I suggest to just remove that call to str() as both are
already in unicode which is perfect => no need to convert with str().


Second part: Fetching mail when some character are broken in the body_html part. It could happend that you receive an email with broking characters in it, you should not block everything because of that. Currently, if it happend, no other mail are fetched, and you got an PostgreSQL error when trying to write it in DB : invalid byte sequence for encoding "UTF8": 0xe96ce9

In the parse_message of mail_message.py, you make everything to take
care of the coding, nothing to improve there I think. But, if the
message (body_html) contain broken char (I mean non-valid one, not a
coding trouble, like in this example : unicode('abcdef' + chr(255))),
then it breaks the mail fetching.

As body_text is encoded in unicode, I suggest the same in my patch, but
with the option errors=ignore. This way we skip all non-conform char,
and ensure the write method will only write valid char in DB.

The provided patch worked on more than 900 mails, so I think it's good.

Thanks for your consideration,

Regards,


Joël


Ref: http://docs.python.org/howto/unicode.html

** Affects: openobject-addons
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of OpenERP
Framework Experts, which is subscribed to OpenERP Addons.
https://bugs.launchpad.net/bugs/921442

Title:
  Encoding trouble in mail_message parsing and base_action_rule
  processing

Status in OpenERP Addons (modules):
  New

Bug description:
  hi,

  
  We've got an issue with encoding in the crm part. This will be difficult to reproduce.. :( So, please look at the code to understand the problem..

  First bug part : Parsing the rules (base_action_rule) breaks if the
  regexp or the name of the resource (model) has some non-string char.
  In the function do_chek you have :

  if reg_name:
              ptrn = re.compile(str(reg_name))
              _result = ptrn.search(str(obj.name))

  Calling str() method here breaks if some unknown char are present in
  the object name or in the regexp name it-self.

  See my patch, I suggest to just remove that call to str() as both are
  already in unicode which is perfect => no need to convert with str().

  
  Second part: Fetching mail when some character are broken in the body_html part. It could happend that you receive an email with broking characters in it, you should not block everything because of that. Currently, if it happend, no other mail are fetched, and you got an PostgreSQL error when trying to write it in DB : invalid byte sequence for encoding "UTF8": 0xe96ce9

  In the parse_message of mail_message.py, you make everything to take
  care of the coding, nothing to improve there I think. But, if the
  message (body_html) contain broken char (I mean non-valid one, not a
  coding trouble, like in this example : unicode('abcdef' + chr(255))),
  then it breaks the mail fetching.

  As body_text is encoded in unicode, I suggest the same in my patch,
  but with the option errors=ignore. This way we skip all non-conform
  char, and ensure the write method will only write valid char in DB.

  The provided patch worked on more than 900 mails, so I think it's
  good.

  Thanks for your consideration,

  Regards,

  
  Joël

  
  Ref: http://docs.python.org/howto/unicode.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/921442/+subscriptions