← Back to team overview

credativ team mailing list archive

Re: [Merge] lp:~credativ/openobject-server/7.0-fixes-syslog into lp:openobject-server/7.0

 

Ok my bad, I hadn't seen that you had made other merge proposal afterward, please discard the previous comments.

So first of all thanks for your merge proposal.
However this is a wishlist for a new feature and we can not accept new features in the stable version (even low risk like this one). This should definitely be made in trunk version.
Could you port your code to trunk ?

Regarding the feature it self, I don't see any reason why not doing so.
Regarding the code, why put a default value to user while it's already LOG_USER in SysLogHandler call ?
Except that looks good to me.
-- 
https://code.launchpad.net/~credativ/openobject-server/7.0-fixes-syslog/+merge/166994
Your team credativ is subscribed to branch lp:~credativ/openobject-server/7.0-fixes-syslog.


References