credativ team mailing list archive

Thread
Date

Re: lp:~savoirfairelinux-openerp/openupgrade-addons/hr_employee_image into lp:openupgrade-addons

To: "Sandy Carter \(http://www.savoirfairelinux.com\)" <sandy.carter@xxxxxxxxxxxxxxxxxxxx>
From: "Stefan Rijnhart \(Therp\)" <stefan@xxxxxxxx>
Date: Fri, 25 Oct 2013 17:32:03 -0000
In-reply-to: <20131025164324.19925.96775.launchpad@ackee.canonical.com>
Reply-to: mp+192728@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information

Slight preference for setting image to NULL in that case. Otherwise, looks alright. Have you tried finding out what encoding the image is in, to see if you could recover the images? That is, if the images are rendered properly in the interface for those employees. Maybe you could post an example string in that case?


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/openupgrade-addons/hr_employee_image/+merge/192728
Your team OpenUpgrade Committers is subscribed to branch lp:openupgrade-addons.

References

lp:~savoirfairelinux-openerp/openupgrade-addons/hr_employee_image into lp:openupgrade-addons
From: Sandy Carter (http://www.savoirfairelinux.com), 2013-10-25