← Back to team overview

cuneiform team mailing list archive

Re: Weird code [Kern\rpic\sources\dll.cpp(207)]

 

On Wed, Dec 31, 2008 at 4:02 PM, Steven Van Ingelgem
<steven@xxxxxxxxxxxxxx> wrote:

> However, gwLowRC is defined as a Word16... Shifting it will ALWAYS result in
> "0".
> Would it be ok to simplify this function to:
> Word32 GetReturnCode_rpic()
> {
>    return gwLowRC + IDS_ERR_NO;
> }

Grepping the source reveals that gwLowRC is always 16 bit (it is
defined in several different places). Maybe it has been 32 bit
sometime earlier?

Converting it to the simple form is ok by me, unless someone has a
reason why it should not be done.



References