← Back to team overview

curtin-dev team mailing list archive

[Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

 

Chad Smith has proposed merging ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master.

Commit message:
storage: correct declared schema draft version for storage schema

python3-jsonschema 3.2 (Ubuntu Focal) pays attention to the $schema
version declared in the provided schema when choosing validators.

Curtin now sets that appropriate schema draft version as 4 instead of
7 to give us better schema errors.


Requested reviews:
  curtin developers (curtin-dev)

For more details, see:
https://code.launchpad.net/~chad.smith/curtin/+git/curtin/+merge/382778
-- 
Your team curtin developers is requested to review the proposed merge of ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master.
diff --git a/curtin/storage_config.py b/curtin/storage_config.py
index 885bf74..eccb96b 100644
--- a/curtin/storage_config.py
+++ b/curtin/storage_config.py
@@ -40,7 +40,7 @@ def get_storage_type_schemas():
 
 
 STORAGE_CONFIG_SCHEMA = {
-    '$schema': 'http://json-schema.org/draft-07/schema#',
+    '$schema': 'http://json-schema.org/draft-04/schema#',
     'name': 'ASTORAGECONFIG',
     'title': 'curtin storage configuration for an installation.',
     'description': (

Follow ups