← Back to team overview

curtin-dev team mailing list archive

Re: [Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

 

Review: Approve

2020-04-22 12:28:20     Odd_Bloke       Were we just mistakenly up-level when we introduced the schema in the first place?
2020-04-22 12:28:40     blackboxsw      Odd_Bloke: yes I think so, and focal is the only place that paid attention
2020-04-22 12:28:41     Odd_Bloke       (Because it doesn't look like we've ever declared our schema as anything but 07.)
2020-04-22 12:29:17     Odd_Bloke       So this is really just aligning the schema with the schema version we use in practice pre-focal?
2020-04-22 12:29:24     Odd_Bloke       blackboxsw: ^
2020-04-22 12:29:30     blackboxsw      yes default schema validator choice in Xenial/Bionic was defaulted to Draft4Validator if no validator cls param was passed to jsonschema.validate()
2020-04-22 12:29:35     Odd_Bloke       OK, cool.
2020-04-22 12:29:50     blackboxsw      focal though actually looks in the defined schema to see that $schema key and decide from there via the function...
-- 
https://code.launchpad.net/~chad.smith/curtin/+git/curtin/+merge/382778
Your team curtin developers is subscribed to branch curtin:master.


References