curtin-dev team mailing list archive
-
curtin-dev team
-
Mailing list archive
-
Message #01332
Re: [Merge] ~mwhudson/curtin:fix-multipath-partition-verification-2 into curtin:master
Diff comments:
> diff --git a/curtin/block/multipath.py b/curtin/block/multipath.py
> index 7ad1791..b1cf777 100644
> --- a/curtin/block/multipath.py
> +++ b/curtin/block/multipath.py
> @@ -88,11 +88,11 @@ def is_mpath_partition(devpath, info=None):
> return result
>
>
> -def mpath_partition_to_mpath_id(devpath):
> +def mpath_partition_to_mpath_id_and_partnumber(devpath):
> """ Return the mpath id of a multipath partition. """
Update the docstring, it also returns the DM_PART value
> info = udev.udevadm_info(devpath)
> if 'DM_MPATH' in info:
> - return info['DM_MPATH']
> + return info['DM_MPATH'], info['DM_PART']
I could have an DM_MPATH device with no partitions; what's this going to return? I suspect this should be info.get('DM_PART')
>
> return None
>
--
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/396462
Your team curtin developers is requested to review the proposed merge of ~mwhudson/curtin:fix-multipath-partition-verification-2 into curtin:master.
References