curtin-dev team mailing list archive

[Michael Hudson-Doyle <mwhudsonlp@xxxxxxxxxxx>]

Diff comments:

> diff --git a/curtin/block/multipath.py b/curtin/block/multipath.py
> index 7ad1791..b1cf777 100644
> --- a/curtin/block/multipath.py
> +++ b/curtin/block/multipath.py
> @@ -88,11 +88,11 @@ def is_mpath_partition(devpath, info=None):
>      return result
>  
>  
> -def mpath_partition_to_mpath_id(devpath):
> +def mpath_partition_to_mpath_id_and_partnumber(devpath):
>      """ Return the mpath id of a multipath partition. """

Good catch

>      info = udev.udevadm_info(devpath)
>      if 'DM_MPATH' in info:
> -        return info['DM_MPATH']
> +        return info['DM_MPATH'], info['DM_PART']

Well see my comment about the strength of the multipath conventions: I really don't think you should have such a device currently. I'll change this to check that both keys are present, seems marginally better than returning None where a string is expected.

>  
>      return None
>  


-- 
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/396462
Your team curtin developers is requested to review the proposed merge of ~mwhudson/curtin:fix-multipath-partition-verification-2 into curtin:master.