curtin-dev team mailing list archive

[Dan Bungert <mp+408913@xxxxxxxxxxxxxxxxxx>]

Review: Needs Information



Diff comments:

> diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
> index aae85c6..ff655cf 100644
> --- a/curtin/commands/block_meta.py
> +++ b/curtin/commands/block_meta.py
> @@ -146,6 +146,8 @@ def write_image_to_disk(source, dev):
>                      '--', source['uri'], devnode])
>      util.subp(['partprobe', devnode])
>      udevadm_settle()
> +    lvm.lvm_scan()
> +    lvm.activate_volgroups()

curtin/block/clear_holders.py has a similar construct, albeit
lvm_scan
activate_volgroups in try/except
then finally udevadm_settle.

The try block around activate_volgroups sounds prudent, what's your thoughts on udevadm_settle before or after this operation?

>      # Images from MAAS have well-known/required paths present
>      # on the rootfs partition.  Use these values to select the
>      # root (target) partition to complete installation.


-- 
https://code.launchpad.net/~alexsander-souza/curtin/+git/curtin/+merge/408913
Your team curtin developers is subscribed to branch curtin:master.