curtin-dev team mailing list archive
-
curtin-dev team
-
Mailing list archive
-
Message #01833
Re: [Merge] ~alexsander-souza/curtin:deploy_raw_lvm_images into curtin:master
Diff comments:
> diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
> index aae85c6..ff655cf 100644
> --- a/curtin/commands/block_meta.py
> +++ b/curtin/commands/block_meta.py
> @@ -146,6 +146,8 @@ def write_image_to_disk(source, dev):
> '--', source['uri'], devnode])
> util.subp(['partprobe', devnode])
> udevadm_settle()
> + lvm.lvm_scan()
> + lvm.activate_volgroups()
The try block really is prudent, I'm going to fix this.
We may need udevadm_settle() before AND after this operation. Before to get the new partition table from the raw image (so LVM can find the PV's), and then after to be certain all the LV's are published before trying to find the roofs.
> # Images from MAAS have well-known/required paths present
> # on the rootfs partition. Use these values to select the
> # root (target) partition to complete installation.
--
https://code.launchpad.net/~alexsander-souza/curtin/+git/curtin/+merge/408913
Your team curtin developers is subscribed to branch curtin:master.
References