curtin-dev team mailing list archive

[Dan Bungert <mp+429404@xxxxxxxxxxxxxxxxxx>]

so far so good, see diff comment

Diff comments:

> diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
> index 5614883..45bec55 100644
> --- a/curtin/commands/block_meta.py
> +++ b/curtin/commands/block_meta.py
> @@ -2054,12 +2071,17 @@ def meta_custom(args):
>                  description="configuring %s: %s" % (command['type'],
>                                                      command['id'])):
>              try:
> -                handler(command, storage_config_dict, command_handlers)
> +                handler(command, storage_config_dict, context)
>              except Exception as error:
>                  LOG.error("An error occured handling '%s': %s - %s" %
>                            (item_id, type(error).__name__, error))
>                  raise
>  
> +    device_map_path = cfg['storage'].get('device_map_path')

Should probably document this config item as well.
This would be a good place to explain the format of the output, though this file is simple enough I don't think it needs much.
Do you anticipate any additional info might be in here?  Trying to decide if we want to place this output under an object so we can have more peers of that object, though I don't know for what.  That might also imply a different name for the config key 'device_map_path'.

Basically, is this file focused on the problem of mapping out real used devices, or is it a general output location for any info that curtin made a decision about that the caller might be interested in?

> +    if device_map_path is not None:
> +        with open(device_map_path, 'w') as fp:
> +            json.dump(context.id_to_device, fp)
> +
>      if args.testmode:
>          util.subp(['losetup', '--detach'] + list(DEVS))
>  


-- 
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/429404
Your team curtin developers is requested to review the proposed merge of ~mwhudson/curtin:FR-2657-record-block-device-path into curtin:master.