curtin-dev team mailing list archive

[Michael Hudson-Doyle <mp+429404@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
> index 5614883..45bec55 100644
> --- a/curtin/commands/block_meta.py
> +++ b/curtin/commands/block_meta.py
> @@ -2054,12 +2071,17 @@ def meta_custom(args):
>                  description="configuring %s: %s" % (command['type'],
>                                                      command['id'])):
>              try:
> -                handler(command, storage_config_dict, command_handlers)
> +                handler(command, storage_config_dict, context)
>              except Exception as error:
>                  LOG.error("An error occured handling '%s': %s - %s" %
>                            (item_id, type(error).__name__, error))
>                  raise
>  
> +    device_map_path = cfg['storage'].get('device_map_path')

Oh yes this definitely needs documentation before merge.

I suppose we could include numbers and offsets for partitions and uuids for filesystems but they're all pretty trivial to find from sysfs or udev once you have the block path. Can you think of anything else we might want to store?

> +    if device_map_path is not None:
> +        with open(device_map_path, 'w') as fp:
> +            json.dump(context.id_to_device, fp)
> +
>      if args.testmode:
>          util.subp(['losetup', '--detach'] + list(DEVS))
>  


-- 
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/429404
Your team curtin developers is requested to review the proposed merge of ~mwhudson/curtin:FR-2657-record-block-device-path into curtin:master.