← Back to team overview

curtin-dev team mailing list archive

Re: [Merge] ~dbungert/curtin:lp-2004609-swap-size-dropped into curtin:master

 

> I needed to revert ebff651 to be able to run the integration tests.

Hmm on which version of Ubuntu? It works for me on kinetic. What goes wrong?

> @mwhudson, what's going on with losetup --partscan, I couldn't find mention of
> a conflict with --sector-size.

losetup with --partscan and --sector-size used to do this:

1) tell the kernel to create a device backed by the supplied file 
2) tell the kernel what sector size to use
3) tell the kernel to scan for partitions

At some point, a shiny new ioctl was added that let you do all of this at once but unfortunately losetup was changed to actually do this:

1) tell the kernel to create a device backed by the supplied file and scan for partitions
2) tell the kernel what sector size to use

As you need to know the sector size to interpret the partition table, this doesn't work.

losetup has been fixed to include the sector size in the ioctl to set everything up (https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/?id=854abba0dd9b45b4f40a9c934694b3f14052eceb) but this hasn't been released yet it seems.
-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/436862
Your team curtin developers is requested to review the proposed merge of ~dbungert/curtin:lp-2004609-swap-size-dropped into curtin:master.



References