← Back to team overview

curtin-dev team mailing list archive

Re: [Merge] ~dbungert/curtin:lp-2004609-swap-size-dropped into curtin:master

 

> Hmm on which version of Ubuntu? It works for me on kinetic.

Up-to-date Lunar

> What goes wrong?

5 tests, all msdos ptable but not every msdos ptable test, fail.  I don't have to revert the full commit listed above to make them 'pass', but commenting out the partprobe done by loop_dev() is enough to make them pass.  Which doesn't give me high confidence.

FAILED tests/integration/test_block_meta.py::TestBlockMeta::test_delete_logical_partition
FAILED tests/integration/test_block_meta.py::TestBlockMeta::test_logical_v2
FAILED tests/integration/test_block_meta.py::TestBlockMeta::test_mix_of_operations_msdos
FAILED tests/integration/test_block_meta.py::TestBlockMeta::test_resize_extended
FAILED tests/integration/test_block_meta.py::TestBlockMeta::test_resize_logical

This is unrelated to this PR, master does so as well.  This seems to be in the realm of 'sysfs is giving unexpected results', as sfdisk -J output looks reasonable if run just before the partprobe.
-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/436862
Your team curtin developers is requested to review the proposed merge of ~dbungert/curtin:lp-2004609-swap-size-dropped into curtin:master.



References