curtin-dev team mailing list archive

[Michael Hudson-Doyle <mp+436862@xxxxxxxxxxxxxxxxxx>]

Review: Approve

So the lesson here is that we should use v2 partitioning for everything?

Diff comments:

> diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
> index 74c491c..9ea543a 100644
> --- a/curtin/commands/block_meta.py
> +++ b/curtin/commands/block_meta.py
> @@ -1097,9 +1097,13 @@ def partition_handler(info, storage_config, context):
>                  partition_type = flag
>              else:
>                  partition_type = "primary"
> -            cmd = ["parted", disk, "--script", "mkpart", partition_type,
> -                   "%ss" % offset_sectors, "%ss" % str(offset_sectors +
> -                                                       length_sectors)]
> +            cmd = ["parted", disk, "--script", "mkpart", partition_type]
> +            if flag == 'swap':
> +                cmd.append("linux-swap")
> +            cmd.extend((
> +               "%ss" % offset_sectors,
> +               "%ss" % str(offset_sectors + length_sectors),

I know it was here before but this str() isn't doing anything

> +            ))
>              if flag == 'boot':
>                  cmd.extend(['set', str(partnumber), 'boot', 'on'])
>  


-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/436862
Your team curtin developers is subscribed to branch curtin:master.