curtin-dev team mailing list archive

[Dan Bungert <mp+469060@xxxxxxxxxxxxxxxxxx>]

Dan Bungert has proposed merging ~dbungert/curtin:noble-unittest-fixes into curtin:master.

Commit message:
do not squash

Requested reviews:
  curtin developers (curtin-dev)

For more details, see:
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/469060

fix several issues related to running tests on noble
in particular, unpin the version of flake8 which is 4 years old
-- 
Your team curtin developers is requested to review the proposed merge of ~dbungert/curtin:noble-unittest-fixes into curtin:master.

diff --git a/test-requirements.txt b/test-requirements.txt
index 487d7da..29f264d 100644
--- a/test-requirements.txt
+++ b/test-requirements.txt
@@ -1,8 +1,9 @@
-pip
-wheel
-virtualenv
+coverage
+flake8
 jsonschema
 nose
-pyflakes
-coverage
 parameterized
+pip
+pyflakes
+virtualenv
+wheel
diff --git a/tools/vmtest-system-setup b/tools/vmtest-system-setup
index 2f82464..bdd1fdc 100755
--- a/tools/vmtest-system-setup
+++ b/tools/vmtest-system-setup
@@ -27,6 +27,7 @@ DEPS=(
   python3-nose
   python3-oauthlib
   python3-parameterized
+  python3-pep8
   python3-pip
   python3-pyflakes
   python3-pytest
diff --git a/tox.ini b/tox.ini
index 573c1f7..228dab0 100644
--- a/tox.ini
+++ b/tox.ini
@@ -15,7 +15,7 @@ downloadcache = ~/cache/pip
 usedevelop = True
 # LC_ALL see https://github.com/gabrielfalcao/HTTPretty/issues/223
 setenv = VIRTUAL_ENV={envdir}
-    LC_ALL = en_US.utf-8
+    LC_ALL = C
 deps = -r{toxinidir}/test-requirements.txt
     -r{toxinidir}/requirements.txt
 # noproxy needed for several of the curtin jenkins jobs
@@ -30,7 +30,6 @@ sitepackages = true
 [testenv:py3-flake8]
 basepython = python3
 deps = {[testenv]deps}
-    flake8==3.8.1
 commands = {envpython} -m flake8 {posargs:curtin tests/}
 
 [testenv:py3-pyflakes]