curtin-dev team mailing list archive

[Michael Hudson-Doyle <mp+469060@xxxxxxxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> diff --git a/tox.ini b/tox.ini
> index 573c1f7..228dab0 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -15,7 +15,7 @@ downloadcache = ~/cache/pip
>  usedevelop = True
>  # LC_ALL see https://github.com/gabrielfalcao/HTTPretty/issues/223
>  setenv = VIRTUAL_ENV={envdir}
> -    LC_ALL = en_US.utf-8
> +    LC_ALL = C

Not a blocker, but why do this?

>  deps = -r{toxinidir}/test-requirements.txt
>      -r{toxinidir}/requirements.txt
>  # noproxy needed for several of the curtin jenkins jobs


-- 
https://code.launchpad.net/~dbungert/curtin/+git/curtin/+merge/469060
Your team curtin developers is subscribed to branch curtin:master.