curtin-dev team mailing list archive

[Dan Bungert <mp+480694@xxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTM, but let me know what you think about the suggestion for the log statement.

Diff comments:

> diff --git a/curtin/storage_config.py b/curtin/storage_config.py
> index dae89f4..6e28187 100644
> --- a/curtin/storage_config.py
> +++ b/curtin/storage_config.py
> @@ -797,8 +833,20 @@ class BlockdevParser(ProbertParser):
>                          break
>  
>                  if part is None:
> -                    raise RuntimeError(
> -                        "Couldn't find partition entry in table")
> +                    # Could not find the partition in the partition table.
> +
> +                    # It is expected for LDM (or Windows dynamic disks).
> +                    # The Linux kernel can discover partitions from the "LDM
> +                    # database" which is stored in the last 1MiB of the disk.
> +                    if self.looks_like_ldm_disk(parent_blockdev):
> +                        part = {

to make sure it doesn't go missing, I did want to log this scenario, since this is what causes partitions to disappear.

> +                            'start': attrs['start'],
> +                            'size': attrs['size'],
> +                            'visible-in-ptable': False,
> +                        }
> +                    else:
> +                        raise RuntimeError(
> +                            "Couldn't find partition entry in table")
>              else:
>                  part = attrs
>  


-- 
https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/480694
Your team curtin developers is subscribed to branch curtin:master.