curtin-dev team mailing list archive

Thread
Date

Re: [Merge] ~medicalwei/curtin:raid-partuuid into curtin:master

To: Yao Wei <yao.wei@xxxxxxxxxxxxx>
From: Olivier Gayot <mp+481164@xxxxxxxxxxxxxxxxxx>
Date: Thu, 13 Feb 2025 10:01:24 -0000
In-reply-to: <173942378404.408387.5504609729322079296.launchpad@scripts-bzrsyncd.lp.internal>
Reply-to: mp+481164@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Review: Approve

I've done more testing and this looks like a nice improvement over what we have today.

I searched in Subiquity private reports and found at least one scenario where we have an entry with ID_PART_TABLE_TYPE=gpt but no ID_PART_ENTRY_SCHEME.

But that entry didn't have a ID_PART_ENTRY_UUID either so it would have been a noop anyway.

Overall, I believe we can't have ID_PART_ENTRY_UUID if we don't have a ID_PART_ENTRY_SCHEME.

LGTM
-- 
https://code.launchpad.net/~medicalwei/curtin/+git/curtin/+merge/481164
Your team curtin developers is subscribed to branch curtin:master.

References

[Merge] ~medicalwei/curtin:raid-partuuid into curtin:master
From: Yao Wei, 2025-02-13