← Back to team overview

curtin-dev team mailing list archive

Re: [Merge] ~medicalwei/curtin:raid-partuuid into curtin:master

 

See inline comment

Diff comments:

> diff --git a/curtin/storage_config.py b/curtin/storage_config.py
> index 8646a2e..872d8fc 100644
> --- a/curtin/storage_config.py
> +++ b/curtin/storage_config.py
> @@ -867,7 +867,7 @@ class BlockdevParser(ProbertParser):
>              if ptable and part.get("visible-in-ptable", True):
>                  entry['size'] *= logical_sector_size
>  
> -            if blockdev_data.get('ID_PART_TABLE_TYPE') == 'gpt':
> +            if blockdev_data.get('ID_PART_ENTRY_SCHEME') == 'gpt':

Thanks Yao.  I want a comment ahead of this line that explains why we are checking ENTRY_SCHEME instead of TABLE_TYPE - today curtin exclusively references TABLE_TYPE for this sort of data.

>                  part_uuid = blockdev_data.get('ID_PART_ENTRY_UUID')
>                  if part_uuid is not None:
>                      entry['uuid'] = part_uuid


-- 
https://code.launchpad.net/~medicalwei/curtin/+git/curtin/+merge/481164
Your team curtin developers is subscribed to branch curtin:master.



References