← Back to team overview

dbusmenu-list team mailing list archive

Re: Timestamp on Events

 

Ted Gould wrote:
> On Fri, 2010-01-22 at 10:15 +0100, Aurélien Gâteau wrote:
>> Ted Gould wrote:
>>> Currently in the event function we have a variant, the goal was for
>>> events like activate we could put the timestamp in there.  Other menu
>>> items could then use it for other events and have a data field to pass
>>> along the data.  What I'm curious about is whether we should leave that
>>> field, and put a standard "timestamp" in there that is always filled.
>>> It seems like something that any event would want and it doesn't cost
>>> much.
>> I agree. It will avoid having to resolve to using a struct if we later
>> need to pack a timestamp + an actual information. Just make sure the
>> timestamp is the last parameter of the method, this way it is easier to
>> ignore it when there is no need for it.
> 
> Merge proposal here:
> 
>   https://code.launchpad.net/~ted/dbusmenu/event-timestamp/+merge/17923
> 
> Thoughts?

Looks good, implementing it in dbusmenu-qt right now.

Aurélien



References