← Back to team overview

dbusmenu-list team mailing list archive

Re: LayoutUpdate vs ChildrenUpdated

 

Ted Gould wrote:
> On Fri, 2010-01-22 at 10:13 +0100, Aurélien Gâteau wrote:
>> Ted Gould wrote:
>>> On Tue, 2010-01-19 at 11:21 +0100, Aurélien Gâteau wrote:
>>>> Naming signals using past tense of verbs looks better IMO and is more
>>>> consistent with the other signals (ItemUpdated and ItemPropertyUpdated).
>>>> I still believe the revision is useless, but I am willing to compromise,
>>>> so what about adopting: "ChildrenUpdated(int revision, uint parentId)"
>>>> or "LayoutUpdated(int revision, uint parentId)"?
>>> I'd prefer LayoutUpdated as it may include more than just the direct
>>> descendants.  For instance, GrandChildren could get updated as well :)
>> Makes sense. Go for LayoutUpdated then.
> 
> Merge request:
> 
>   https://code.launchpad.net/~ted/dbusmenu/layout-updated/+merge/17929

Thanks, implementing this on my side as well.

Aurélien



References