debcrafters-packages team mailing list archive

[Pragyansh Chaturvedi <2115319@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

rpicam-apps fails to build with the following log:
https://launchpadlibrarian.net/800476781/buildlog_ubuntu-questing-arm64.rpicam-apps_1.7.0-1ubuntu1ppa2_BUILDING.txt.gz

libpisp has an API change, where void compute_optimal_stride(pisp_image_format_config &config) changed to void compute_optimal_stride(pisp_image_format_config &config, bool preserve_subsample_ratio = false)
This function is used in libcamera's PiSP driver.

This change causes no problems in the no change rebuild of libcamera,
but rpicam-apps builds with libcamera  with "-Wl, --no-undefined" and
thus fails with an undefined symbol error due to this change.

Instead of adding a default parameter, overloading this function to emit
symbols for both one argument and two arguments variants is a better fix
than turning on --no-undefined for rpicam-apps.

** Affects: libpisp (Ubuntu)
     Importance: Undecided
     Assignee: Pragyansh Chaturvedi (r41k0u)
         Status: New

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to libpisp in Ubuntu.
https://bugs.launchpad.net/bugs/2115319

Title:
  API breakage in libpisp causes FTBFS in rpicam-apps

Status in libpisp package in Ubuntu:
  New

Bug description:
  rpicam-apps fails to build with the following log:
  https://launchpadlibrarian.net/800476781/buildlog_ubuntu-questing-arm64.rpicam-apps_1.7.0-1ubuntu1ppa2_BUILDING.txt.gz

  libpisp has an API change, where void compute_optimal_stride(pisp_image_format_config &config) changed to void compute_optimal_stride(pisp_image_format_config &config, bool preserve_subsample_ratio = false)
  This function is used in libcamera's PiSP driver.

  This change causes no problems in the no change rebuild of libcamera,
  but rpicam-apps builds with libcamera  with "-Wl, --no-undefined" and
  thus fails with an undefined symbol error due to this change.

  Instead of adding a default parameter, overloading this function to
  emit symbols for both one argument and two arguments variants is a
  better fix than turning on --no-undefined for rpicam-apps.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libpisp/+bug/2115319/+subscriptions