debcrafters-packages team mailing list archive

[Launchpad Bug Tracker <2115319@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package libpisp - 1.2.1-2ubuntu1

---------------
libpisp (1.2.1-2ubuntu1) questing; urgency=medium

  * d/p/fix-libpisp-api.patch: Fix API breakage by overloading
    libpisp::compute_optimal_stride (LP: #2115319)
    - compute_optimal_stride's signature was recently changed by adding another
      default parameter to it. This does not cause any problem in building
      libcamera.so, but any executable that builds with libcamera using the
      -Wl, --no-undefined flag will FTBFS. (this is the case with rpicam-apps)
    - This change overloads the function so the symbol exported previously is
      still present in libpisp.so, while also having the new function.

 -- Pragyansh Chaturvedi <pragyansh.chaturvedi@xxxxxxxxxxxxx>  Wed, 25
Jun 2025 12:37:21 +0530

** Changed in: libpisp (Ubuntu)
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to libpisp in Ubuntu.
https://bugs.launchpad.net/bugs/2115319

Title:
  API breakage in libpisp causes FTBFS in rpicam-apps

Status in libpisp package in Ubuntu:
  Fix Released
Status in rpicam-apps package in Ubuntu:
  New

Bug description:
  rpicam-apps fails to build with the following log:
  https://launchpadlibrarian.net/800476781/buildlog_ubuntu-questing-arm64.rpicam-apps_1.7.0-1ubuntu1ppa2_BUILDING.txt.gz

  libpisp has an API change, where void compute_optimal_stride(pisp_image_format_config &config) changed to void compute_optimal_stride(pisp_image_format_config &config, bool preserve_subsample_ratio = false)
  This function is used in libcamera's PiSP driver.

  This change causes no problems in the no change rebuild of libcamera,
  but rpicam-apps builds with libcamera  with "-Wl, --no-undefined" and
  thus fails with an undefined symbol error due to this change.

  Instead of adding a default parameter, overloading this function to
  emit symbols for both one argument and two arguments variants is a
  better fix than turning off --no-undefined for rpicam-apps.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libpisp/+bug/2115319/+subscriptions