debcrafters-packages team mailing list archive

[Mitchell Augustin <2119336@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Upstream patch: 
https://github.com/util-linux/util-linux/commit/875d6a31d7d5042a382fd7a4612e24f1582b062e

SRU Justification:

On the version of lsblk in Jammy, lsblk does not recognize the ID column
when passed as a desired output option.

[ Impact ]

The availability of the ID column in JSON output is helpful since it
allows lsblk's users to key off the disk ID, rather than disk names,
which could be ephemeral. (see https://github.com/util-linux/util-
linux/issues/1658 for more related discussion).


[ Test Plan ]

Control test:
Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` without the patch. Observe that it prints `lsblk: unknown column: ID,TRAN,TYPE,SIZE`.

Fix test:
Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` with the patch. Observe that it prints the expected JSON rather than erroring out.

[ Fix ]

The proposed patch adds support for the ID column to lsblk via the
addition of a new case in device_get_data().


[ Where problems could occur ]

The regression risk should be minimal here, since the diff only adds a
new code path to lsblk that, when currently taken, results in an error.

** Affects: util-linux (Ubuntu)
     Importance: Undecided
     Assignee: Mitchell Augustin (mitchellaugustin)
         Status: In Progress

** Changed in: util-linux (Ubuntu)
     Assignee: (unassigned) => Mitchell Augustin (mitchellaugustin)

** Changed in: util-linux (Ubuntu)
       Status: New => In Progress

** Summary changed:

- lsblk: id column is missing
+ lsblk: id column is missing in Jammy

-- 
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2119336

Title:
  lsblk: id column is missing in Jammy

Status in util-linux package in Ubuntu:
  In Progress

Bug description:
  Upstream patch: 
  https://github.com/util-linux/util-linux/commit/875d6a31d7d5042a382fd7a4612e24f1582b062e

  SRU Justification:

  On the version of lsblk in Jammy, lsblk does not recognize the ID
  column when passed as a desired output option.

  [ Impact ]

  The availability of the ID column in JSON output is helpful since it
  allows lsblk's users to key off the disk ID, rather than disk names,
  which could be ephemeral. (see https://github.com/util-linux/util-
  linux/issues/1658 for more related discussion).

  
  [ Test Plan ]

  Control test:
  Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` without the patch. Observe that it prints `lsblk: unknown column: ID,TRAN,TYPE,SIZE`.

  Fix test:
  Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` with the patch. Observe that it prints the expected JSON rather than erroring out.

  [ Fix ]

  The proposed patch adds support for the ID column to lsblk via the
  addition of a new case in device_get_data().

  
  [ Where problems could occur ]

  The regression risk should be minimal here, since the diff only adds a
  new code path to lsblk that, when currently taken, results in an
  error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/2119336/+subscriptions