debcrafters-packages team mailing list archive

Thread
Date

[Bug 2119336] Re: lsblk: id column is missing in Jammy

To: debcrafters-packages@xxxxxxxxxxxxxxxxxxx
From: Mitchell Augustin <2119336@xxxxxxxxxxxxxxxxxx>
Date: Tue, 05 Aug 2025 23:28:51 -0000
Reply-to: Bug 2119336 <2119336@xxxxxxxxxxxxxxxxxx>
Sender: noreply@xxxxxxxxxxxxx

Prerequisite patches applied to MP and listed in bug report. This is now
ready for review.

PPA: https://launchpad.net/~mitchellaugustin/+archive/ubuntu/lsblk-id-
column-test/+packages

** Description changed:

Upstream patch:
+ https://github.com/util-linux/util-linux/commit/875d6a31d7d5042a382fd7a4612e24f1582b062e
+
+ Prerequisites also applied:
+ https://github.com/util-linux/util-linux/commit/d1574dae64ca1dca67b69702257519c6ca53db8c
+ https://github.com/util-linux/util-linux/commit/ef7d50a0cc59d3b55587c8ea5fa45db45b888aee
+ https://github.com/util-linux/util-linux/commit/e054895f4a22680cfd41f875b842f1544090d379
https://github.com/util-linux/util-linux/commit/875d6a31d7d5042a382fd7a4612e24f1582b062e

SRU Justification:

On the version of lsblk in Jammy, lsblk does not recognize the ID column
when passed as a desired output option.

[ Impact ]

The availability of the ID column in JSON output is helpful since it
allows lsblk's users to key off the disk ID, rather than disk names,
which could be ephemeral. (see https://github.com/util-linux/util-
linux/issues/1658 for more related discussion).

[ Test Plan ]

Control test:
Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` without the patch. Observe that it prints `lsblk: unknown column: ID,TRAN,TYPE,SIZE`.

Fix test:
Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` with the patch. Observe that it prints the expected JSON rather than erroring out.

This can be compared to the result when the noble util-linux is
installed on the same machine, to ensure both are equal.

[ Fix ]

The proposed patch adds support for the ID column to lsblk via the
addition of a new case in device_get_data().

[ Where problems could occur ]

The regression risk should be minimal here, since the diff only adds a
new code path to lsblk that, when currently taken, results in an error.

** Description changed:

Upstream patch:
https://github.com/util-linux/util-linux/commit/875d6a31d7d5042a382fd7a4612e24f1582b062e

Prerequisites also applied:
https://github.com/util-linux/util-linux/commit/d1574dae64ca1dca67b69702257519c6ca53db8c
https://github.com/util-linux/util-linux/commit/ef7d50a0cc59d3b55587c8ea5fa45db45b888aee
https://github.com/util-linux/util-linux/commit/e054895f4a22680cfd41f875b842f1544090d379
https://github.com/util-linux/util-linux/commit/875d6a31d7d5042a382fd7a4612e24f1582b062e

SRU Justification:

On the version of lsblk in Jammy, lsblk does not recognize the ID column
when passed as a desired output option.

[ Impact ]

[ Test Plan ]

Control test:
Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` without the patch. Observe that it prints `lsblk: unknown column: ID,TRAN,TYPE,SIZE`.

Fix test:
Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` with the patch. Observe that it prints the expected JSON rather than erroring out.

This can be compared to the result when the noble util-linux is
installed on the same machine, to ensure both are equal.

[ Fix ]

The proposed patch adds support for the ID column to lsblk via the
addition of a new case in device_get_data().

[ Where problems could occur ]

- The regression risk should be minimal here, since the diff only adds a
- new code path to lsblk that, when currently taken, results in an error.
+ The regression risk should be minimal here, since the functional diff only adds a new code path to lsblk that, when currently taken, results in an error.
+ There is a small refactor that was present in https://github.com/util-linux/util-linux/commit/d1574dae64ca1dca67b69702257519c6ca53db8c that is also represented in this delta, but it only adjusts the semantics/readability of the check to ensure that the udev device exists, so no user-visible change is expected.

--
You received this bug notification because you are a member of
Debcrafters packages, which is subscribed to util-linux in Ubuntu.
https://bugs.launchpad.net/bugs/2119336

Title:
lsblk: id column is missing in Jammy

Status in util-linux package in Ubuntu:
In Progress

Bug description:
Upstream patch:
https://github.com/util-linux/util-linux/commit/875d6a31d7d5042a382fd7a4612e24f1582b062e

SRU Justification:

On the version of lsblk in Jammy, lsblk does not recognize the ID
column when passed as a desired output option.

[ Impact ]

[ Test Plan ]

Control test:
Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` without the patch. Observe that it prints `lsblk: unknown column: ID,TRAN,TYPE,SIZE`.

Fix test:
Run `./lsblk -J -o NAME,ID,TRAN,TYPE,SIZE` with the patch. Observe that it prints the expected JSON rather than erroring out.

This can be compared to the result when the noble util-linux is
installed on the same machine, to ensure both are equal.

[ Fix ]

The proposed patch adds support for the ID column to lsblk via the
addition of a new case in device_get_data().

[ Where problems could occur ]

The regression risk should be minimal here, since the functional diff only adds a new code path to lsblk that, when currently taken, results in an error.
There is a small refactor that was present in https://github.com/util-linux/util-linux/commit/d1574dae64ca1dca67b69702257519c6ca53db8c that is also represented in this delta, but it only adjusts the semantics/readability of the check to ensure that the udev device exists, so no user-visible change is expected.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/2119336/+subscriptions

References

[Bug 2119336] [NEW] lsblk: id column is missing in Jammy
From: Mitchell Augustin, 2025-08-01