deja-dup-team team mailing list archive

Thread
Date

Re: [Merge] lp:~kaie/deja-dup/deja-dup into lp:deja-dup

To: Kai Engert <kaie@xxxxxxx>
From: Michael Terry <michael.terry@xxxxxxxxxxxxx>
Date: Mon, 18 Mar 2013 01:59:24 -0000
In-reply-to: <20130316124119.4746.74910.launchpad@ackee.canonical.com>
Reply-to: mp+153656@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

This is fine in theory, and thanks so much for the patch!  However, I would prefer the inverse check.  That is, test for a GNOME-Shell-specific dbus address and only allow ShellEnv.GNOME if it's found.

(I'd rather do it this way because I prefer the status icon UI too, and only GNOME Shell has requested the no-status-icon route.)
-- 
https://code.launchpad.net/~kaie/deja-dup/deja-dup/+merge/153656
Your team Déjà Dup Developers is subscribed to branch lp:deja-dup.

Follow ups

Re: [Merge] lp:~kaie/deja-dup/deja-dup into lp:deja-dup
From: Kai Engert, 2013-03-18
Re: [Merge] lp:~kaie/deja-dup/deja-dup into lp:deja-dup
From: Kai Engert, 2013-03-18

References

[Merge] lp:~kaie/deja-dup/deja-dup into lp:deja-dup
From: Kai Engert, 2013-03-16