← Back to team overview

desktop-packages team mailing list archive

[Bug 1101573] Re: Coverity FORWARD_NULL - CID 12445 - plugins/animation/src/animation.cpp - in function: PrivateAnimScreen::initiateCloseAnim(PrivateAnimWindow *) - Comparing "effectToBePlayed" to null implies that "effectToBePlayed" might be null.

 

** Changed in: compiz
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to compiz in Ubuntu.
https://bugs.launchpad.net/bugs/1101573

Title:
  Coverity FORWARD_NULL - CID 12445 -
  plugins/animation/src/animation.cpp - in function:
  PrivateAnimScreen::initiateCloseAnim(PrivateAnimWindow *) - Comparing
  "effectToBePlayed" to null implies that "effectToBePlayed" might be
  null.

Status in Compiz:
  Fix Committed
Status in Compiz 0.9.9 series:
  Won't Fix
Status in compiz package in Ubuntu:
  Fix Released

Bug description:
  This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
  CID: 12445
  Checker: FORWARD_NULL
  Category: No category available
  CWE definition: http://cwe.mitre.org/data/definitions/476.html
  File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/animation.cpp
  Function: PrivateAnimScreen::initiateCloseAnim(PrivateAnimWindow *)
  Code snippet:
  1930 	    AnimEffect effectToBePlayed =
  1931 		getActualEffect (chosenEffect, AnimEventClose);
  1932 
  1933 	    // handle empty random effect list
  CID 12445 - FORWARD_NULL
  Comparing "effectToBePlayed" to null implies that "effectToBePlayed" might be null.
  1934 	    if (effectToBePlayed && effectToBePlayed == AnimEffectNone)
  1935 	    {
  1936 		aw->mState = aw->mNewState;
  1937 		return;
  1938 	    }
  1939

To manage notifications about this bug go to:
https://bugs.launchpad.net/compiz/+bug/1101573/+subscriptions