desktop-packages team mailing list archive

Thread
Date

[Bug 1101573] Re: Coverity FORWARD_NULL - CID 12445 - plugins/animation/src/animation.cpp - in function: PrivateAnimScreen::initiateCloseAnim(PrivateAnimWindow *) - Comparing "effectToBePlayed" to null implies that "effectToBePlayed" might be null.

To: desktop-packages@xxxxxxxxxxxxxxxxxxx
From: Launchpad Bug Tracker <1101573@xxxxxxxxxxxxxxxxxx>
Date: Mon, 30 Mar 2015 20:51:22 -0000
Reply-to: Bug 1101573 <1101573@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

This bug was fixed in the package compiz -
1:0.9.12.1+15.04.20150330-0ubuntu1

---------------
compiz (1:0.9.12.1+15.04.20150330-0ubuntu1) vivid; urgency=medium

  [ Chris Townsend ]
  * Change default behavior of focus-follows-mouse where the desktop
    will get focus when the mouse is over it. Also add option to allow
    old behavior. (LP: #1427636)
  * Clear out the lastMask vars when using the mouse to resize. (LP:
    #1348254)

  [ Eleni Maria Stea ]
  * Minor optimisation fix: Replaced glLoadIdentity, glMultMatrixf with
    glLoadMatrixf to avoid the unnecessary matrix multiplication:
    identity * some projection matrix

  [ Kevin Lange ]
  * WinRules plugin: boost arbitrary window size limits to something
    more reasonable (LP: #1431923)

  [ Stephen M. Webb ]
  * animations plugin: fixed a potential null pointer dereference (LP:
    #1101573)
 -- CI Train Bot <ci-train-bot@xxxxxxxxxxxxx>   Mon, 30 Mar 2015 15:58:21 +0000

** Changed in: compiz (Ubuntu)
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to compiz in Ubuntu.
https://bugs.launchpad.net/bugs/1101573

Title:
  Coverity FORWARD_NULL - CID 12445 -
  plugins/animation/src/animation.cpp - in function:
  PrivateAnimScreen::initiateCloseAnim(PrivateAnimWindow *) - Comparing
  "effectToBePlayed" to null implies that "effectToBePlayed" might be
  null.

Status in Compiz:
  In Progress
Status in Compiz 0.9.9 series:
  Won't Fix
Status in compiz package in Ubuntu:
  Fix Released

Bug description:
  This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
  CID: 12445
  Checker: FORWARD_NULL
  Category: No category available
  CWE definition: http://cwe.mitre.org/data/definitions/476.html
  File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/animation.cpp
  Function: PrivateAnimScreen::initiateCloseAnim(PrivateAnimWindow *)
  Code snippet:
  1930 	    AnimEffect effectToBePlayed =
  1931 		getActualEffect (chosenEffect, AnimEventClose);
  1932 
  1933 	    // handle empty random effect list
  CID 12445 - FORWARD_NULL
  Comparing "effectToBePlayed" to null implies that "effectToBePlayed" might be null.
  1934 	    if (effectToBePlayed && effectToBePlayed == AnimEffectNone)
  1935 	    {
  1936 		aw->mState = aw->mNewState;
  1937 		return;
  1938 	    }
  1939

To manage notifications about this bug go to:
https://bugs.launchpad.net/compiz/+bug/1101573/+subscriptions