← Back to team overview

desktop-packages team mailing list archive

[Bug 33288]

 

I went through the patch written by me and unfortunately I can not make
it so that it returns the same result as before. I've separated axes in
which it searches for immediate up/down/left/right neighbours, sorted
them and found the neighbours by single pass (+ number of possible
neighbour candidates in the other axis for given block, which should be
sqrt(n) in average case).

The difference is that the patch searches for right-down neighbour by looking at down neighbour of its right neighbour and at the right neighbour of its down neighbour. If they match then it selects it as the right-bottom neighbour.
Previous version just searched for the closest block which is to the right of the block and below the block (and looking at the code, the result could depend on order of the blocks in the searched array).

Modifying the patch so that it would return the same results as without it would cost the whole efficiency.
Anyway, the efficiency improvement of my patch is not as big as the one from Brian so you can reject it (but I think that it improves the conversion :) ).

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/33288

Title:
  Evince doesn't handle columns properly

Status in Poppler:
  Confirmed
Status in poppler package in Ubuntu:
  Fix Released
Status in poppler source package in Lucid:
  Fix Released

Bug description:
  So, now that RC is here, let's propose it as an SRU.
  I've pushed it in lucid-proposed. The debdiff is poppler_0.12.4-0ubuntu4_2_0.12.4-0ubuntu5.debdiff attached there for information. I'm removing old debdiff to avoid confusion.

  poppler (0.12.4-0ubuntu5) lucid-proposed; urgency=low

    * debian/patches/11_column_selection.patch:
      - backport from upstream git commit to fix wrong selection in pdf when
        containing tables, long text, broken flow and so on.
        (fixing most of known issues with selection in pdf) (LP: #33288)

  
  ----------------------------
  ----------------------------

  When making a multi column selection from a PDF like this:

  http://www.specialist-games.com/mordheim/assets/lrb/1Rules.pdf

  And pasting the result into OpenOffice.org the columns are not
  maintained. The results unusable because the text from both columns
  becomes mixed.

  Please note, this is not a PDF problem, using Adobe Acrobat Reader 7.x
  under Windows does properly copy-paste columned text over to
  OpenOffice.org.

  Regards,
  Pascal de Bruijn

To manage notifications about this bug go to:
https://bugs.launchpad.net/poppler/+bug/33288/+subscriptions