← Back to team overview

desktop-packages team mailing list archive

[Bug 1101554] Re: Coverity FORWARD_NULL - CID 12448 - plugins/animation/src/dodge.cpp - in function: DodgeAnim::calculateDodgeAmounts() - Dynamic cast to pointer "dynamic_cast <DodgeAnim *>(curAnim)" can return NULL. Assigning: "dodgeAnim" = "dynamic_cast <DodgeAnim *>(curAnim)". Later dereferencing null pointer "dodgeAnim".

 

This bug was fixed in the package compiz -
1:0.9.12.0+15.04.20141210.2-0ubuntu1

---------------
compiz (1:0.9.12.0+15.04.20141210.2-0ubuntu1) vivid; urgency=medium

  [ James Jones ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Kyle Brenneman ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Viktor A. Danilov ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Chris Townsend ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Stephen M. Webb ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)
  * libdecoration/CMakeLists.txt: use correct variable for link
    directories (LP: #1392715)
  * Switcher Plugin: renamed a local variable so it does not hide a
    function parameter. (LP: #1101585)
  * added support for multi-arch installations (LP: #1395105, #959282)
  * libcompizconfig: reorder stat() and open() calls to eliminate a race
    condition (LP: #1101608)
  * dodge plugin: avoid potential null pointer dereferences (LP:
    #1101554)
  * PrivateScreen unit tests: added additional assertions to verify the
    tests are run in an expected state (LP: #1101413)

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Brandon Schaefer ]
  * Rev 3891 change caused 2 known regressions. (Could be more).
    Reverting. (LP: #1398512, #1393020)
 -- Ubuntu daily release <ps-jenkins@xxxxxxxxxxxxxxxxxxx>   Wed, 10 Dec 2014 19:52:06 +0000

** Changed in: compiz (Ubuntu)
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to compiz in Ubuntu.
https://bugs.launchpad.net/bugs/1101554

Title:
  Coverity FORWARD_NULL - CID 12448 - plugins/animation/src/dodge.cpp -
  in function: DodgeAnim::calculateDodgeAmounts() - Dynamic cast to
  pointer "dynamic_cast <DodgeAnim *>(curAnim)" can return NULL.
  Assigning: "dodgeAnim" = "dynamic_cast <DodgeAnim *>(curAnim)". Later
  dereferencing null pointer "dodgeAnim".

Status in Compiz:
  In Progress
Status in Compiz 0.9.9 series:
  Won't Fix
Status in compiz package in Ubuntu:
  Fix Released

Bug description:
  This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
  CID: 12448
  Checker: FORWARD_NULL
  Category: dynamic_cast
  CWE definition: http://cwe.mitre.org/data/definitions/476.html
  File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/animation/src/dodge.cpp
  Function: DodgeAnim::calculateDodgeAmounts()
  Code snippet:
  792 
  793 	    Animation *curAnim = awCur->curAnimation ();
  794 	    if (!curAnim || curAnim->info () != AnimEffectDodge)
  795 		continue;
  CID 12448 - FORWARD_NULL
  Dynamic cast to pointer "dynamic_cast <DodgeAnim *>(curAnim)" can return NULL.
  Assigning: "dodgeAnim" = "dynamic_cast <DodgeAnim *>(curAnim)".
  796 	    DodgeAnim *dodgeAnim = dynamic_cast<DodgeAnim *> (curAnim);
  797 
  CID 12448 - FORWARD_NULL
  Dereferencing null pointer "dodgeAnim".
  798 	    dodgeAnim->mDodgeMaxAmountX = dodgeAmountX + offsetX;
  799 	    dodgeAnim->mDodgeMaxAmountY = dodgeAmountY + offsetY;
  800 	    dodgeAnim->mDodgeDirection = dodgeDirection;
  801

To manage notifications about this bug go to:
https://bugs.launchpad.net/compiz/+bug/1101554/+subscriptions