← Back to team overview

desktop-packages team mailing list archive

[Bug 1101413] Re: Coverity CHECKED_RETURN - CID 12406 - src/privatescreen/tests/test-privatescreen.cpp - in function: privatescreen_ButtonPressEdgeEventManagementTest_NoTriggerOnUnboundAction_Test::TestBody() - No check of the return value of "option.set(value)".

 

This bug was fixed in the package compiz -
1:0.9.12.0+15.04.20141210.2-0ubuntu1

---------------
compiz (1:0.9.12.0+15.04.20141210.2-0ubuntu1) vivid; urgency=medium

  [ James Jones ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Kyle Brenneman ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Viktor A. Danilov ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Chris Townsend ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Stephen M. Webb ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)
  * libdecoration/CMakeLists.txt: use correct variable for link
    directories (LP: #1392715)
  * Switcher Plugin: renamed a local variable so it does not hide a
    function parameter. (LP: #1101585)
  * added support for multi-arch installations (LP: #1395105, #959282)
  * libcompizconfig: reorder stat() and open() calls to eliminate a race
    condition (LP: #1101608)
  * dodge plugin: avoid potential null pointer dereferences (LP:
    #1101554)
  * PrivateScreen unit tests: added additional assertions to verify the
    tests are run in an expected state (LP: #1101413)

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Brandon Schaefer ]
  * Rev 3891 change caused 2 known regressions. (Could be more).
    Reverting. (LP: #1398512, #1393020)
 -- Ubuntu daily release <ps-jenkins@xxxxxxxxxxxxxxxxxxx>   Wed, 10 Dec 2014 19:52:06 +0000

** Changed in: compiz (Ubuntu)
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to compiz in Ubuntu.
https://bugs.launchpad.net/bugs/1101413

Title:
  Coverity CHECKED_RETURN - CID 12406 - src/privatescreen/tests/test-
  privatescreen.cpp - in function:
  privatescreen_ButtonPressEdgeEventManagementTest_NoTriggerOnUnboundAction_Test::TestBody()
  - No check of the return value of "option.set(value)".

Status in Compiz:
  Triaged
Status in Compiz 0.9.9 series:
  Won't Fix
Status in compiz package in Ubuntu:
  Fix Released

Bug description:
  This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
  CID: 12406
  Checker: CHECKED_RETURN
  Category: No category available
  CWE definition: http://cwe.mitre.org/data/definitions/252.html
  File: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/privatescreen/tests/test-privatescreen.cpp
  Function: privatescreen_ButtonPressEdgeEventManagementTest_NoTriggerOnUnboundAction_Test::TestBody()
  Code snippet:
  1239     MockTriggerableAction triggerableAction;
  1240     ce::EventArguments    arguments;
  1241     int                   edgeMask = 1 << SCREEN_EDGE_TOP;
  1242 
  CID 12406 - CHECKED_RETURN
  Calling function "CompOption::set(CompOption::Value &)" without checking return value (as is done elsewhere 1171 out of 1219 times).
  No check of the return value of "option.set(value)".
  1243     option.set (value);
  1244 
  1245     const ce::ActionModsMatchesEventStateFunc &matchEventState =
  1246 	    GetMatchEventStateFuncForMock (triggerableAction);
  1247 
  1248     EXPECT_FALSE (ce::activateButtonPressOnEdgeBindingOption (option,

To manage notifications about this bug go to:
https://bugs.launchpad.net/compiz/+bug/1101413/+subscriptions