desktop-packages team mailing list archive

[Leo Iannacone <l3on@xxxxxxxxxx>]

Public bug reported:

Hi,

in ubuntu_show_titlebar.patch you are acting like:


if DE == GNOME:
    pass // let nautilus as default

else:
   apply changes // show the "old" titlebar


I think this kind of approach is a bit wrong in some cases. You want
show titlebar only for Unity, so you may want to check in this way:

if DE == Unity:
    apply changes // show the "old" titlebar

else:
    pass  // let nautilus as default


this permits other DE, based on mutter (like budgie or just a simple mutter instance), to run Nautilus as expected.


Please consider to change this kind of patch.

** Affects: nautilus (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1414584

Title:
  Change behavior of ubuntu_show_titlebar.patch

Status in nautilus package in Ubuntu:
  New

Bug description:
  Hi,

  in ubuntu_show_titlebar.patch you are acting like:

  
  if DE == GNOME:
      pass // let nautilus as default

  else:
     apply changes // show the "old" titlebar


  I think this kind of approach is a bit wrong in some cases. You want
  show titlebar only for Unity, so you may want to check in this way:

  if DE == Unity:
      apply changes // show the "old" titlebar

  else:
      pass  // let nautilus as default

  
  this permits other DE, based on mutter (like budgie or just a simple mutter instance), to run Nautilus as expected.

  
  Please consider to change this kind of patch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1414584/+subscriptions