dhis2-devs team mailing list archive

[Lars Helge Øverland <larshelge@xxxxxxxxx>]

2009/4/14 Bob Jolliffe <bobjolliffe@xxxxxxxxx>

> 2009/4/14 Lars Helge Øverland <larshelge@xxxxxxxxx>:
> >
> >>
> >> Yes, we have a list of pressing requirements, one is implementing
> >> "easy-access-help" and the other is "datavalue-history". For
> implementing
> >> first one I had small discussion with you, and we decided that I will
> look
> >> shortly if migrating from webwork to struts2 is possible. I managed to
> >> migrate one module to run on struts2, it is possible but takes some time
> and
> >> efforts. As all of us know webwork is not updated since mid 2007
> >
> > Yes, but we should still have a review of struts 2 before launching into
> > it... Anyway there are hundreds of action classes, interceptors etc and
> it
> > will be a big job to change things.
>
> My count is just over 400 actions.  And considerably fewer
> interceptors.  Mind you the transition from webwork to struts2 doesn't
> appear catastrophic
> (http://struts.apache.org/2.0.14/docs/key-changes-from-webwork-2.html)
> and probably a good bit could be automated.  But I know, the devil is
> always in the detail :-)  But I agree with Murod - sitting on webwork
> past its expiry date is a risk.  The trouble is that such a migration
> can't be a gradual one like the hibernate case.  I guess it would be a
> case of migrate one and all ...
>
> Reminds me how it would be really useful to have some sort of selenium
> test suite   I wonder what came of Satvik's efforts to put together a
> list of test cases for the webapp.  Satvik, I saw the beginning of
> this - can you share what you have?
>
> What would the steps be in looking at such a proposal?  Something like
> 1.  review of struts2 and its differences from webwork leading to a
> decision and prioritisation
> 2.  compilation of selenium style battery tests covering at least the
> results of 400 actions!  Probably not all at once, but generally
> something useful in itself.
> 3.  creation of a migration branch
> 4.  auto-convert as much as possible
> 5.  cycle of test and fix what's still broken
>


Sounds reasonable.

I am not saying switching to struts is a bad thing (I guess struts2 is more
of a webwork continuation with some struts additions ++), just that it takes
time and its a question of priority..