dhis2-devs team mailing list archive

[Saptarshi Purkayastha <sunbiz@xxxxxxxxx>]

Hi lars,

   -  We are using the Indian theme and blue is by default... Will do it for
the other themes in parts. Looked at solving the Indian needs at first
;-)... will now move to the next ones.

   -  The logo_banner.png was changed because instead of using a JavaScript
hack to get the png in IE, I felt it was better to remove the transparency
and use the same background color.

   -  The moveAll function did not work in IE6 and instead all the calls
were through moveAllByID. Jquery does it in a single line and hence, didn't
see the use of moveAll function... If anyone's module is affected (which I
couldn't find), I suggest that you may want to use moveAllByID.

   -  The functionality of locking.js was not working in IE6 as it is and
hence the changes had to be made

   -  The padding is different because the application name gets into the
maintainance text at the lower resolution and hence the right padding had to
be smaller. And don't know why the paddings have to be same on both sides??
Some bias to symmetry??

   -  Exactly my question, do we have a code style file that I can use with
my IDE?? I couldn't find it uploaded in launchpad... Someone can post the
codestyle file in the Downloads section.

BTW, isn't it a common norm in the Java world to have the { (opening
brackets) on the same line as method instead of newline??

on the blueprint I added "Needs Code Review", so that people can comment
like this. I hope others respond with their views as well... Other people
who are working on blueprints should also use this status on blueprints, so
that we can have better code quality.

---
Regards,
Saptarshi PURKAYASTHA
Director R & D, HISP India
Health Information Systems Programme

My Tech Blog:  http://sunnytalkstech.blogspot.com
You Live by CHOICE, Not by CHANCE


2009/4/18 Lars Helge Øverland <larshelge@xxxxxxxxx>

>
>
>
> Hi,
>
> nice work with the ie6 compliance. I have a few humble comments:
>
> - You have only done updates for the blue skin. This makes things
> inconsistent, please update the rest.
>
> - Why have you changed logo_banner.png? In my browser this is no longer
> vertically centered.
>
> - Why did you remove the moveAll function? Have you made sure it is not
> used at all in the system?
>
> - Even if you have changed locking.js, this type of functionality can be
> found in lots of places in the system which makes things inconsistent. Also
> I thought this part worked in IE6? Can we have it the way it was?
>
> - The right side padding of the logo is less than the left side padding,
> can you make this even?
>
> - You are using a different code style then the system default. I am not
> saying your style is bad, but the point of having a codestyle is that things
> should look the same, now we have different code styles which is ugly.
>
>
>
>
> Lars
>
>
>
>
>
> On Sat, Apr 18, 2009 at 1:13 AM, <noreply@xxxxxxxxxxxxx> wrote:
>
>> ------------------------------------------------------------
>> revno: 191
>> committer: sunbiz <sunbiz@hispindia>
>> branch nick: trunk
>> timestamp: Sat 2009-04-18 04:43:07 +0530
>> message:
>>  blueprints:ie6-compliance,low-res. Other js fixes for all browsers...
>> Author: Zafar, Bharath, Seid - new India theme part of v1 Indian deployment
>> added:
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/india/
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/india/dom.js
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/india/head.png
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/india/india.css
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/india/logo_background.png
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/india/logo_banner.png
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/india/logo_left.png
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/india/logo_right.png
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/india/logo_separator.png
>> modified:
>>  dhis-2/dhis-options/src/main/resources/META-INF/dhis/beans.xml
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/blue/blue.css
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/blue/logo_banner.png
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/css/blue/logo_right.png
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/security/logo_banner.png
>>
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/util/lists.js
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/main.js
>>  dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/request.js
>>
>>  dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/webapp/dhis-web-maintenance-dataadmin/javascript/locking.js
>>
>>  dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/webapp/dhis-web-maintenance-dataadmin/lockingForm.vm
>>
>>  dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/webapp/dhis-web-maintenance-dataadmin/menu.vm
>>
>>  dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/webapp/dhis-web-maintenance-datadictionary/dataElementGroupEditor.vm
>>
>>  dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/webapp/dhis-web-maintenance-datadictionary/javascript/dataElementGroupEditor.js
>>
>> The size of the diff (2263 lines) is larger than your specified limit of
>> 1000 lines
>>
>> --
>> Trunk
>> https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk<https://code.launchpad.net/%7Edhis2-devs-core/dhis2/trunk>
>>
>> Your team DHIS 2 developers is subscribed to branch lp:dhis2.
>> To unsubscribe from this branch go to
>> https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription<https://code.launchpad.net/%7Edhis2-devs-core/dhis2/trunk/+edit-subscription>
>> .
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> More help   : https://help.launchpad.net/ListHelp
>
>