dhis2-devs team mailing list archive

[Lars Helge Øverland <larshelge@xxxxxxxxx>]

Hi Saptarshi,

thanks for commenting...

On Sat, Apr 18, 2009 at 1:11 PM, Saptarshi Purkayastha <sunbiz@xxxxxxxxx>wrote:

> Hi lars,
>
>    -  We are using the Indian theme and blue is by default... Will do it
> for the other themes in parts. Looked at solving the Indian needs at first
> ;-)... will now move to the next ones.


OK great no prob.


>
>
>    -  The logo_banner.png was changed because instead of using a JavaScript
> hack to get the png in IE, I felt it was better to remove the transparency
> and use the same background color.


Hmm.. It is nice to have these transparent PNGs, and way more flexible than
merging in the background. This would require us to do this for all skins as
well. If we want to change the logo it's better to be able to do it one
place. MS just released IE8, we shouldn't put TOO much effort in serving
IE6. I would very much like to have it the way it was...



>
>
>    -  The moveAll function did not work in IE6 and instead all the calls
> were through moveAllByID. Jquery does it in a single line and hence, didn't
> see the use of moveAll function... If anyone's module is affected (which I
> couldn't find), I suggest that you may want to use moveAllByID.


Sure I see. I'm just saying its a little dangerous to remove things from the
common javascript files as we are not getting errors until runtime if things
are broken. Maybe a grep on the code base would be nice here. Can't think of
any places it is used though.


>
>
>    -  The functionality of locking.js was not working in IE6 as it is and
> hence the changes had to be made


OK fine. But as far as I know there are other places with similar code
(datamart, report table etc), is this working?


>
>
>    -  The padding is different because the application name gets into the
> maintainance text at the lower resolution and hence the right padding had to
> be smaller. And don't know why the paddings have to be same on both sides??
> Some bias to symmetry??


Well I believe most web-pages adhere to this, and I think it looks much
better, yes...


>
>
>    -  Exactly my question, do we have a code style file that I can use with
> my IDE?? I couldn't find it uploaded in launchpad... Someone can post the
> codestyle file in the Downloads section.


You can find it here:
http://208.76.222.114/confluence/display/DOC/Code+Conventions (on the middle
of the page)


>
>
> BTW, isn't it a common norm in the Java world to have the { (opening
> brackets) on the same line as method instead of newline??
>

Might be, but all javascripts in the system are written similar to the java
code style, and it looks weird with different styles. If there are strong
arguments for changing the style that is fine with me, but then everything
should be changed.



>
> on the blueprint I added "Needs Code Review", so that people can comment
> like this. I hope others respond with their views as well... Other people
> who are working on blueprints should also use this status on blueprints, so
> that we can have better code quality.
>


Yes this is very useful. Also, make sure we set blueprints to "started" so
we avoid duplication of work and can get a view of what people are working
on.