← Back to team overview

dhis2-devs team mailing list archive

Re: [Branch ~dhis2-devs-core/dhis2/trunk] Rev 835: Quickly fixed ...

 

Hi Thuy

I see the class
GenerateAdvancedReportExcelOrganisationGroupListingAction.java

exists in the package:
package org.hisp.dhis.reportexcel.export.advance.action;

If you think of the package as providing some sort of namespace scoping,
then there is no need to repeat the words from the package in the name of
the class.

In which case I think
GenerateOrganisationGroupListingAction

is adequate.  Its "fully qualified" name would be:
org.hisp.dhis.reportexcel.export.advance.action.GenerateOrganisationGroupListingAction

Regards
Bob

2009/10/8 Thuy Nguyen <thuy.hispvietnam@xxxxxxxxx>

> GenerateAdvancedReportExcelOrganisationGroupListingAction.java
>
>
> Generate for generating
> Advanced for advanced function of Generating report.
> Report Excel is for seperate Report Excel module
> OrganisationGroupListing is a report type (Normal, Category, PeriodListing
> type)
>
> ReportExcelOrganisationGroupListing was required by Lars.
>
>
>
>
> --
> --
> Thuy
> HISP Vietnam
> +84902079126
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs<https://launchpad.net/%7Edhis2-devs>
> More help   : https://help.launchpad.net/ListHelp
>
>

References