← Back to team overview

dhis2-devs team mailing list archive

Re: Aggregate indicators

 

Hi,

I also faced a similar situation when I tried to create an indicator using
expressions from two other indicators. I think it comes when a limit is
exceeded. It displays expression error and stops working. Could be a bug.

Regards
Pramil

On Sat, Apr 30, 2016 at 7:41 AM, Juan Manuel Alcantara Acosta <
jmalcantara1@xxxxxxxxx> wrote:

> Thanks Mark
> When I mentioned the need of a face lift for the editor, I was looking at
> the interface in 2.21 (20997), which is the version where I see the
> errors creating the indicator, sorry I forgot to mention that small bit of
> info ;-)
>
> Best regards,
> JM
>
>
> El 29/04/2016, a las 10:42 a.m., Mark Polak <mark@xxxxxxxxx> escribió:
>
> Hey Juan,
>
> I'm open to suggestions on how to improve the usability of the indicator
> editor :) I think if you could come up with some things you would like to
> see changed i can see what i can do.
>
> 20k constants sounds like something that would need searchable constants
> (which it currently doesn't support iirc). Your knowledge of how it is used
> is obviously greater than mine, so if you have any ideas on how it
> could/would work better, feel free to share them and then i can see what we
> can do here to improve that.
>
> Basically please supply a wishlist, but no guarantees for presents ;)
> (things that i can do with the current API are more easily achievable than
> things that need server side work)
>
> Regards,
>
> Mark
>
> On Fri, Apr 29, 2016 at 5:31 PM, Juan Manuel Alcantara Acosta <
> jmalcantara1@xxxxxxxxx> wrote:
>
>> Hi Jason
>> Good to hear form you, I hope you are well.
>>
>> I agree, that is a good solution and it works very well when you
>> implement it as a function you can call form a SQL View, then you can use
>> the API to setup a cron job or use other means to take care of the
>> frequency. There is a lot you can do with this approach.
>> I was also able to setup the indicator using the API, but we want to
>> allow the user to create these indicators. Both SQL and the API are a
>> little beyond what they can or want to do. I think the indicator editor is
>> due for an face lift ;-) there are other things to consider, for example
>> having 20K constants to choose from or formulas that requires a data
>> element with an option combination that is not part of the category
>> combination assigned to the data element.
>>
>> Best regards,
>> JM
>>
>>
>>
>>
>>
>> El 29/04/2016, a las 8:30 a.m., Jason Pickering <
>> jason.p.pickering@xxxxxxxxx> escribió:
>>
>> Hi JM,
>>
>> Sounds like a bug, but quite crazy to attempt as well!
>>
>> Another way to do this, though perhaps not ideal, would be to perform
>> this calculation through SQL and inject it back into the system as a data
>> element. We have followed this approach for indicators which cannot be
>> calculated with relatively simple formulas provided by indicators, such as
>> those requiring "IF...THEN" types of calculations.
>>
>> Not ideal, but it might be an approach you wish to consider.
>>
>> Regards,
>> Jason
>>
>>
>> On Fri, Apr 29, 2016 at 3:24 PM, Juan Manuel Alcantara Acosta <
>> jmalcantara1@xxxxxxxxx> wrote:
>>
>>> Hi Lars
>>> Thank you, I looked at the database and the interface and I didn’t see a
>>> limit imposed by either one. I have a formula that sums 410 data elements,
>>> I know that sounds impractical but that’s just the way it’s required.
>>> When I build the formula, with ~300 data elements I get error #1, with
>>> the 400 I get error #2
>>>
>>> Best regards,
>>> JM
>>>
>>>
>>> Error #1
>>> jquery.min.js?_rev=20997:2 GET
>>> https://test-data.ippf.org/api/expressions/description?expression=%23%7BcIm…cZiZ%7D%0A%2B%23%7BAV0dSekxPXl%7D%0A%2B%23%7BINM6uMXWoeK%7D%0A%0A%0A%0A%0A
>>> <https://test-data.ippf.org/api/expressions/description?expression=%23%7BcIm%E2%80%A6cZiZ%7D%0A%2B%23%7BAV0dSekxPXl%7D%0A%2B%23%7BINM6uMXWoeK%7D%0A%0A%0A%0A%0A>
>>> net::ERR_SPDY_PROTOCOL_ERRORsend @ jquery.min.js?_rev=20997:2p.extend.ajax
>>> @ jquery.min.js?_rev=20997:2getExpressionText @
>>> expressionBuilder.js?_rev=20997:82cleanExpression @
>>> expressionBuilder.js?_rev=20997:111onchange @
>>> showUpdateIndicatorForm.action?id=65566:584
>>>
>>>
>>> Error #2
>>> jquery.min.js?_rev=20997:2 GET
>>> https://test-data.ippf.org/api/expressions/description?expression=%23%7BcIm…eFqW%7D%0A%2B%23%7BePqg2GN87Ng%7D%0A%2B%23%7BFTrvVVBrdry%7D%0A%0A%0A%0A%0A
>>> <https://test-data.ippf.org/api/expressions/description?expression=%23%7BcIm%E2%80%A6eFqW%7D%0A%2B%23%7BePqg2GN87Ng%7D%0A%2B%23%7BFTrvVVBrdry%7D%0A%0A%0A%0A%0A>
>>> 400 ()send @ jquery.min.js?_rev=20997:2p.extend.ajax @
>>> jquery.min.js?_rev=20997:2getExpressionText @
>>> expressionBuilder.js?_rev=20997:82cleanExpression @
>>> expressionBuilder.js?_rev=20997:111onchange @
>>> showUpdateIndicatorForm.action?id=65566:584
>>>
>>>
>>>
>>> El 28/04/2016, a las 1:40 a.m., Lars Helge Øverland <lars@xxxxxxxxx>
>>> escribió:
>>>
>>> Hi JM,
>>>
>>> there is no hard limit (beyond 2gb expression length;).
>>>
>>> However data analytics performance (and entry forms if you have
>>> indicators there) will of course suffer with extremely large indicators.
>>>
>>> regards,
>>>
>>> Lars
>>>
>>>
>>> On Wed, Apr 27, 2016 at 11:44 PM, Juan Manuel Alcantara Acosta <
>>> jmalcantara1@xxxxxxxxx> wrote:
>>>
>>>> Hi Devs
>>>> Is there a limit on the number of data elements that can be added in an
>>>> indicator formula?
>>>> Regards,
>>>> JM
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~dhis2-devs
>>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~dhis2-devs
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>>
>>>
>>> --
>>> Lars Helge Øverland
>>> Lead developer, DHIS 2
>>> University of Oslo
>>> Skype: larshelgeoverland
>>> http://www.dhis2.org <https://www.dhis2.org/>
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~dhis2-devs
>>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~dhis2-devs
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>>
>> --
>> Jason P. Pickering
>> email: jason.p.pickering@xxxxxxxxx
>> tel:+46764147049 <+46764147049>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~dhis2-devs
>> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~dhis2-devs
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
>
> --
> Regards,
>
>
> Mark Polak
> Software developer, DHIS 2
> University of Oslo
> http://www.dhis2.org <https://www.dhis2.org/>
> mark@xxxxxxxxx
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to     : dhis2-devs@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help   : https://help.launchpad.net/ListHelp
>
>

References