dhis2-devs team mailing list archive
-
dhis2-devs team
-
Mailing list archive
-
Message #50635
Issue completing dataSets offline
Hi devs,
I think I've spotted a couple of issues with completing data sets in Data
Entry.
There's a couple of uses of the completeDataSetRegistrations endpoint with
ds,pe, e.t.c. params but it looks like it's expecting dataSet, period e.t.c.
https://github.com/dhis2/dhis2-core/blob/d63e1930fb9828bd361cb5e4d1d81089aaed2dc7/dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js#L2160
https://github.com/dhis2/dhis2-core/blob/d63e1930fb9828bd361cb5e4d1d81089aaed2dc7/dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js#L3017
This AJAX call doesn't give a 'type' so it results in a GET, but I'm
guessing it's supposed to be a POST:
https://github.com/dhis2/dhis2-core/blob/d63e1930fb9828bd361cb5e4d1d81089aaed2dc7/dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js#L402
Can I ask that this be backported as well?
Thanks,
- Jasper
Follow ups