divmod-dev team mailing list archive

[Werner Thie <927179@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The code in Athena/__init__.js  at line 1130 detaches only every other
client

for (var i = 0; i < self.childWidgets.length; ++i) {
    self.childWidgets[i]._athenaDetachClient();

Possible fix by creating a copy of the widgets list could be:

        var childWidgets = self.childWidgets.slice();   //copy self.childWidgets, it will be modified by removeChildWidget
      
        for (var i = 0; i < self.childWidgets.length; ++i)  {
            childWidgets[i] = self.childWidgets[i];
        }
        for (var i = 0; i < childWidgets.length; ++i)  {
            childWidgets[i]._athenaDetachClient();

This is a bug for which I submitted the above fix and necessary test when divmod.org was still active
How do I proceed?

Thxs, Werner

** Affects: nevow
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Divmod-
dev, which is the registrant for nevow.
https://bugs.launchpad.net/bugs/927179

Title:
  _athenaDetachClient detaches only every other client

Status in Divmod Nevow:
  New

Bug description:
  The code in Athena/__init__.js  at line 1130 detaches only every other
  client

  for (var i = 0; i < self.childWidgets.length; ++i) {
      self.childWidgets[i]._athenaDetachClient();

  Possible fix by creating a copy of the widgets list could be:

          var childWidgets = self.childWidgets.slice();   //copy self.childWidgets, it will be modified by removeChildWidget
        
          for (var i = 0; i < self.childWidgets.length; ++i)  {
              childWidgets[i] = self.childWidgets[i];
          }
          for (var i = 0; i < childWidgets.length; ++i)  {
              childWidgets[i]._athenaDetachClient();

  This is a bug for which I submitted the above fix and necessary test when divmod.org was still active
  How do I proceed?

  Thxs, Werner

To manage notifications about this bug go to:
https://bugs.launchpad.net/nevow/+bug/927179/+subscriptions