divmod-dev team mailing list archive

[Glyph Lefkowitz <glyph@xxxxxxxxxxxxxxxxx>]

On Jan 8, 2013, at 8:20 AM, Jean-Paul Calderone <exarkun@xxxxxxxxxxxxxxxxx> wrote:

>> If the request is to split the merge proposal into 2 patches ... why not.
> 
> Yes, that's what I was requesting (so that I can only reject the setuptools change while not rejecting the unittest2 change).
> 
>> For me, they are complementary changes to improve testing, so it makes sense to propose them together.
> 
> Many, many, many, many changes are complementary.  That doesn't mean they should be made simultaneously.  Changesets should focus on one change, not many complementary changes.  Basically, the smallest useful change is what you should try to make.  That way issues with *unrelated* changes don't hold up useful improvements, reviews are easier, the history is easier to navigate, tickets can have simple descriptions, and problems that require changes to be reverted don't also revert working functionality.

My feelings about setuptools are somewhat more ambivalent, but this point is more important.  The fact that this discussion about setuptools is happening is now holding up an unrelated change.  If the changes were split up, the less controversial parts (which are by far the larger part of these changes) could be discussed on their own merits and landed much more quickly.


-- 
https://code.launchpad.net/~florent.x/pyflakes/1097061-unittest2/+merge/142224
Your team Divmod-dev is requested to review the proposed merge of lp:~florent.x/pyflakes/1097061-unittest2 into lp:pyflakes.